-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Simplify conditions #3846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify conditions #3846
Conversation
zend_compile.c: zend_is_variable(). Removed unnecessary checks. Namin…
Reorder conditions and "if else" blocks. More light and probable to top. Join nested "if"s to parent "if" or "else" if no branching.
merge from head
merge head
gmp_random() was removed
Done
Unnecessary checks has been removed. All test is pass.
Splitted into two functions. Maybe make them
This comment has been hidden by github, so I noticed it after pushing last commit, sorry :) |
@nikic All is done |
… into simplify_conditions
Merged as 1be120f. Thanks! |
Merged nested "if"s
Extracted complex checks into functions
Deduplicated some checks