-
Notifications
You must be signed in to change notification settings - Fork 7.9k
enable cli opcache starting with php 7.1 #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
failing travis build looks unrelated: |
Merged 71fe529 Thanks. |
* PHP-7.1: merge PR #2290: enable opcache in CLI in 7.1+
There's been some complaints that this negatively impacts memory usage and startup time of PHP on CLI. Especially without the file cache, whether or not having opcache enabled on CLI is beneficial will depend a lot on the script, how many backing files it has and how long it runs. I would suggest reverting this change. |
I'd be telling same. The file cache only could be useful at least, but it cannot be enabled by default and thus it cannot be used Python alike. Under this circumstances, enabling on CLI by defauls seems rather an overkill having more negative impact than improvement. Thanks. |
This reverts commit 71fe529. Without the file cache (which is not enabled by default), this has non-trivial impact on the startup time. It also significantly increases the baseline memory usage of PHP on CLI.
Reverted via e9ff1fa. |
* master: (89 commits) Replace ASN1_STRING_data with ASN1_STRING_get0_data Fix leak in WDDX serialization Travis: Use opcache in release build Implemented FR #71520 Fixed bug #69373 Fix bug #74607: Don't check for bi-directional compatibility in traits Fix bug #55407 Fixed bug #73473: Stack Buffer Overflow in msgfmt_parse_message openssl_pkcs12_read: add missing BIO_free Add basic test for posix_setegid function Set timezone for intl/test/bug74298.phpt Revert "merge PR php#2290: enable opcache in CLI in 7.1+" PCRE_EXTRA_MARK is useful only for preg_replace_callbakc(). Removed branch expectations. Added support for PCRE JIT fast path API Escape value passed to exec() Ignore spurious stderr output from lsof ZVAL_COPY_UNREF() micro-optimization test for ErrorException::getSeverity(); improve dns (checkdnsrr) test coverage test to function forward_static_call_array(); ...
as discussed in #2238 (comment)