Skip to content

Fix #70103: Fix bug 70103 when ZTS is enabled #2282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mhagstrand
Copy link
Contributor

Used snprintf to copy the basename string before it is freed

========DIFF========
002+ string(6) "hp-src"
002- string(7) "foo.txt"
========DONE========
FAIL Bug #70103 (ZipArchive::addGlob ignores remove_all_path option) [ext/zip/tests/bug70103.phpt] 

https://travis-ci.org/php/php-src/jobs/189428235

Used snprintf to copy the basename string before it is freed
@krakjoe krakjoe self-assigned this Jan 6, 2017
@mhagstrand
Copy link
Contributor Author

mhagstrand commented Jan 6, 2017

@cmb69 Can you take a look at the change since this is a change to your fix on #1430

@cmb69
Copy link
Member

cmb69 commented Jan 6, 2017

Good catch, Mitch. Thanks! I'm going to merge this PR.

@cmb69
Copy link
Member

cmb69 commented Jan 6, 2017

@krakjoe This PR is not testing related, but rather fixes a use after free which my recently merged PR #1430 introduced.

@krakjoe
Copy link
Member

krakjoe commented Jan 6, 2017

@cmb69 and I knew that, because I read it ... fingers are faster than brain sometimes :D

ta ...

@php-pulls
Copy link

Comment on behalf of cmb at php.net:

Applied with commit ad08aa3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants