Fix bug #55138 PDO OCI cannot insert more than 1332 bytes #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging Christopher as he is the Oracle guy; @cjbj |
cjbj
reviewed
Jan 24, 2017
| } | ||
|
|
||
| /* we can provide as much data as value_sz can fit */ | ||
| value_sz = SB4MAXVAL; |
There was a problem hiding this comment.
A change which sets value_sz to SB4MAXVAL for non LONG columns would cause something similar to bug 72524 which affected PHP OCI8. We (Oracle) will do some more work before suggesting a fix.
|
Since there has been no updates or input from anyone in more than a year, I'm going to close this PR. If I'm wrong to do that, and you would like to continue to work on this, please open a fresh PR targeting an appropriate branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for issue #633