Fix dom class can't be inherited by the internal class #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the background for this change? |
|
@nikic When create new extension define class zend_register_internal_class_ex(&my_ce, dom_element_class_entry);Happen error <?php
$html = <<<HTML
<a href="a">a</a>
HTML;
$document = new \DOMDocument();
$document->registerNodeClass("\\DOMElement", "\\MyDOMElement");
$document->loadHTML(html);
$node = $document->childNodes->item(1);
var_dump($node, $node->nodeName); |
|
Comparing class entries directly looks and feels wrong ... |
|
Maybe check against the module entry of the class instead? |
|
If type equal |
|
To clarify, what I meant is checking for something like |
|
@nikic Thank you, I changed. |
php-pulls
pushed a commit
that referenced
this pull request
Jan 1, 2017
php-pulls
pushed a commit
that referenced
this pull request
Jan 1, 2017
php-pulls
pushed a commit
that referenced
this pull request
Jan 1, 2017
This reverts commit 299e02c.
|
Please check tests ... |
php-pulls
pushed a commit
that referenced
this pull request
Jan 1, 2017
This reverts commit a9aefe5.
|
@krakjoe Sorry, Now it's OK. |
|
Re-merged via 3c97761, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.