Fix for sporadic segfault with MYSQLI_OPT_INT_AND_FLOAT_NATIVE #2250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug #73800
|
Comment on behalf of krakjoe at php.net: labelling |
|
You mentioned on the bug report that this issue is not reproducible deterministically. Maybe it would be possible to create a test that consistently generates a warning when run under valgrind? Otherwise the fix looks correct (though imho what we're doing in read_text_protocol_aux is horrible and we might want to copy the values to a stack buffer for conversion instead). |
php-pulls
pushed a commit
that referenced
this pull request
Jan 2, 2017
Fixes bug #73800 news entry for PR #2250
|
Merged 732f67e Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #73800