Fix bug #74796: Requests through http proxy set peer name #18523
+202
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
openssl_bug74796_http_proxy_peer_name
branch
from
34ae0fe to
9f08216
Compare
bukka
force-pushed
the
openssl_bug74796_http_proxy_peer_name
branch
from
9f08216 to
e4e9744
Compare
This issue happens because http wrapper sets peer_name but then does not remove so it stays in the context. The fix removes the peer name from the context after enabling crypto. In addition to bug #74796, this also fixes bug #76196. In addition it should be a final fix for those SOAP bugs: bug #69783 bug #52913 bug #61463
bukka
force-pushed
the
openssl_bug74796_http_proxy_peer_name
branch
from
e4e9744 to
fb18b94
Compare
|
I have been debugging the Windows test failure which was due to the fact that it the server connection is closed immediately after write on Windows and then it's read by client, it produces error (it's probably related how pipes work on Windows). Syncing the comms is a bit tricky in this case as it can be driven just by client so for now I just added small delay before close which seems to work. It might need some revisiting if we see any related failures after this gets merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue happens because http wrapper sets peer_name but then does not
remove so it stays in the context. The fix removes the peer name from
the context after enabling crypto.
In addition to bug #74796, this also fixes bug #76196.
In addition it should be a final fix for those SOAP bugs:
bug #69783
bug #52913
bug #61463