Use custom OpenSSL libctx in md and cipher handling code #18516
+252
−114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a bit more work to free stuff correctly so moving to draft. |
bukka
force-pushed
the
openssl_libctx_md_and_cipher
branch
from
e8e295b to
4b93dca
Compare
bukka
force-pushed
the
openssl_libctx_md_and_cipher
branch
from
4b93dca to
2655b22
Compare
|
Pipeline is green so this is ready for review! |
nielsdos
reviewed
May 22, 2025
|
|
||
| const EVP_CIPHER *php_openssl_get_evp_cipher_from_algo(zend_long algo) | ||
| { | ||
| if (algo < 0 || algo >= (zend_long)(sizeof(php_openssl_cipher_names) / sizeof(*php_openssl_cipher_names))) { |
There was a problem hiding this comment.
One neat trick is to make the type of algo zend_ulong. Then you only need the >= check and don't need the zend_long cast. Same suggestion for php_openssl_get_evp_md_from_algo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The is another chunk of work to support custom libctx - this time in cipher and message digest code.