Skip to content

Fixed GH-18267 finfo_file() crashing on invalid URL protocol. #18269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

Fixed GH-18267 finfo_file() crashing on invalid URL protocol. #18269

merged 1 commit into from
Apr 8, 2025
+17 −0

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Apr 7, 2025

No description provided.

@devnexen devnexen marked this pull request as ready for review April 7, 2025 21:47
@devnexen devnexen requested a review from Girgias April 7, 2025 21:47
Girgias
Girgias requested changes Apr 8, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a guard after the call to php_stream_context_from_zval in PHP_FUNCTION(finfo_file) instead of removing this assertion.

@Girgias
Copy link
Member

Girgias commented Apr 8, 2025

Seems like you hit some file conflicts for open_basedir ... wonder if this is something that needs to be fixed too. Just rerunning the CI

@devnexen
Copy link
Member Author

devnexen commented Apr 8, 2025

Seems like you hit some file conflicts for open_basedir ... wonder if this is something that needs to be fixed too. Just rerunning the CI

Oh right ..

Girgias
Girgias reviewed Apr 8, 2025
View reviewed changes
@Girgias Girgias merged commit 2d39c78 into php:master Apr 8, 2025
9 checks passed
@devnexen devnexen deleted the gh18267 branch April 8, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
Extension: fileinfo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias