Skip to content

Simplify curl gc handlers #18227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Simplify curl gc handlers #18227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ext/curl/interface.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,9 @@ static HashTable *curl_get_gc(zend_object *object, zval **table, int *n)

zend_get_gc_buffer_use(gc_buffer, table, n);

return zend_std_get_properties(object);
/* CurlHandle can never have properties as it's final and has strict-properties on.
* Avoid building a hash table. */
return NULL;
}

zend_result curl_cast_object(zend_object *obj, zval *result, int type)
Expand Down
4 changes: 3 additions & 1 deletion ext/curl/multi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,7 +594,9 @@ static HashTable *curl_multi_get_gc(zend_object *object, zval **table, int *n)

zend_get_gc_buffer_use(gc_buffer, table, n);

return zend_std_get_properties(object);
/* CurlMultiHandle can never have properties as it's final and has strict-properties on.
* Avoid building a hash table. */
return NULL;
}

static zend_object_handlers curl_multi_handlers;
Expand Down
Loading