Skip to content

Build fix: Address deprecated PHP 8.4 session options to prevent test… #18179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

willvar
Copy link
Contributor

@willvar willvar commented Mar 29, 2025

… failures

Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've encountered this problem myself too but just changed my ini file.
I'm going to merge this into 8.4, for future fixes: you should always target the lowest bugfix-supported branch that the bug applies to. Since this was deprecated in 8.4 the right branch would thus be PHP-8.4 not master 🙂

@nielsdos nielsdos closed this in aa7c8a9 Mar 31, 2025
@willvar
Copy link
Contributor Author

willvar commented Apr 1, 2025

Apologies for submitting the fix to the incorrect branch.

This contribution stems from my ongoing maintenance of several PHP extensions in the AUR. Since PHP 8.4 was released in Arch Linux, these modules have failed the make test command due to the unexpected deprecation warnings in the test output. After verifying the issue, I concluded that this behavior change should be addressed upstream to ensure consistent testing standards across all maintained packages.

Thank you for your guidance on the proper workflow!

@nielsdos
Copy link
Member

nielsdos commented Apr 1, 2025

Thank you for your maintenance dedication!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants