Skip to content

Fix GH-18145: basic_globals_ctor initialization #18156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-18145: basic_globals_ctor initialization #18156

wants to merge 1 commit into from

Conversation

bukka
Copy link
Member

@bukka bukka commented Mar 26, 2025

This resets all basic globals during ctor and just modifies the ones with a special value. It also switches to using basic_globals_p which what should be used in this context.

@bukka bukka linked an issue Mar 26, 2025 that may be closed by this pull request
php8ts crashes in php_clear_stat_cache() #18145
Closed
@bukka bukka requested a review from nielsdos March 26, 2025 21:37
nielsdos
nielsdos approved these changes Mar 26, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this should work

@bukka bukka closed this in 2197a49 Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

php8ts crashes in php_clear_stat_cache()
2 participants
@bukka @nielsdos