Skip to content

Fix intl tests for icu 77 #18125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Fix intl tests for icu 77 #18125

merged 2 commits into from
Mar 21, 2025

Conversation

nielsdos
Copy link
Member

No description provided.

Comment on lines +320 to +322
disp_locale=en : display_name=Chinese #China(, A_MYEXT(_X_PRIVATE)?)?, a=myext, Private-Use=private#
disp_locale=fr : display_name=chinois #Chine(, A_MYEXT(_X_PRIVATE)?)?, a=myext, usage privé=private#
disp_locale=de : display_name=Chinesisch #China(, A_MYEXT(_X_PRIVATE)?)?, a=myext, Privatnutzung=private#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix is different to the one in the other file. Maybe unify?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idc too much but sure

@nielsdos nielsdos merged commit 8823f89 into php:PHP-8.3 Mar 21, 2025
8 of 9 checks passed
nielsdos added a commit that referenced this pull request Mar 21, 2025
* PHP-8.3:
  Fix intl tests for icu 77 (#18125)
nielsdos added a commit that referenced this pull request Mar 21, 2025
* PHP-8.4:
  Fix intl tests for icu 77 (#18125)
iluuu1994 added a commit that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants