Skip to content

Fix OSS-Fuzz #403308724 #18074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix OSS-Fuzz #403308724 #18074

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Mar 15, 2025 •
edited
Loading

Because hooks can be nested (via anon classes) without starting a new context (at least at the point we set the property information), we need to restore the old property info in case of nested hooks.

@nielsdos
Fix OSS-Fuzz #403308724
1944fe2 
Because simple hooks can be nested without starting a new context, we
need to restore the old property info in case of nested hooks.
@nielsdos nielsdos requested a review from iluuu1994 March 15, 2025 10:34
iluuu1994
iluuu1994 approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a bit odd that we have to install the property info on an unrelated context frame. Alternatively, we could push a new empty frame when entering anonymous classes. Either way, this approach should be fine.

@nielsdos nielsdos closed this in 4fd9992 Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994