test to function stream_socket_sendto(); #1804
Conversation
was add a new test to stream module
|
Needs skipif for online tests. |
|
Hello @krakjoe how are you? thanks for your comment! |
|
@krakjoe Thanks! |
| --FILE-- | ||
| <?php | ||
| $serverUri = "tcp://127.0.0.1:31854"; | ||
| $serverUrl = "http://yahoo.com"; |
There was a problem hiding this comment.
This should be php.net, since we try not to rely on third party, which we do not control
| marcosptf - <marcosptf@yahoo.com.br> - @phpsp - sao paulo - br | ||
| --SKIPIF-- | ||
| <?php | ||
| if (phpversion() < "5.3.0") { |
There was a problem hiding this comment.
This should be removed, like in your other PRs, no need to check for PHP versions
|
@marcosptf what @krakjoe means is that you need to have the following condition in your SKIPIF section when you have tests that does stuff online: if (getenv("SKIP_ONLINE_TESTS")) { die('skip: online test'); } |
| die("Test stream_socket_enable_crypto has failed; Unable to connect: {$errstr} ({$errno})"); | ||
| } | ||
| ?> | ||
| --CLEAN-- |
There was a problem hiding this comment.
I forgot to mention, but the entire --CLEAN-- section is not needed, as I explained in another PR, then its run in a separate script after, so the variables do no longer exists, if anything, this should be done in --FILE--, but php already does this once the script ends :)
There was a problem hiding this comment.
Besides the removal of the --CLEAN-- section, then this PR is fine, thanks for your work!
|
Hi @KalleZ fix done! Thanks!!! |
* PHP-7.0: add stream_socket_sendto test from PR #1804
* PHP-7.1: add stream_socket_sendto test from PR #1804
was add a new test to stream module