Skip to content

Intl locale compose isref #18035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Intl locale compose isref #18035

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

No description provided.

nielsdos
nielsdos reviewed Mar 12, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php-src/ext/intl/locale/locale_methods.c

Line 1440 in 00e2ee1

ZEND_HASH_FOREACH_VAL(hash_arr, ele_value) {
here's another loop that probably doesn't handle refs properly?

@devnexen
Copy link
Member Author

I admit I did not look this one because it s another function.

nielsdos
nielsdos approved these changes Mar 12, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well this one is fine, feel free to either handle the other function here as well or in another PR.

@devnexen devnexen force-pushed the intl_locale_compose_isref branch from 96b963b to 1bf49ee Compare March 12, 2025 22:00
@devnexen devnexen closed this in c3fc94c Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

Assignees
No one assigned
Labels
Extension: intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @nielsdos