Skip to content

Fix flaky conneciton count in mysql test #18030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix flaky conneciton count in mysql test #18030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions ext/mysqli/tests/bug73462.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
--TEST--
Bug #73462 (Persistent connections don't set $connect_errno)
--EXTENSIONS--
mysqli
all
Comment on lines 3 to +4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the --EXTENSIONS-- section.

Marking as conflicting with all would only solve the problem if there is another test not properly marked as conflicting with mysql. Possibly, there are other connections (not caused by our tests) involved anyway?

Copy link
Member Author

@iluuu1994 iluuu1994 Mar 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I had a complete brain fart. 🙂 I'm not sure this makes sense at all. And yes, as you correctly assumed I read this as --CONFLICTS--.

--SKIPIF--
<?php
require_once('skipifconnectfailure.inc');
/*
* TODO: this test is flaky with persistent connections on PPC CI runner
* [001] Expected '8711' got '8712'.
*/
if (gethostname() == "php-ci-ppc64be") {
die("SKIP test is flaky");
}
?>
--FILE--
<?php
Expand Down
Loading