Code

Typed Properties#1797

Code

Closed

krakjoe wants to merge 210 commits intophp:masterphp/php-src:masterfrom

krakjoe:typed-propertiesCopy head branch name to clipboard

Commits

Commits on Mar 5, 2016

• initial import

  krakjoe

  committed
  d5e097e

  Copy full SHA for d5e097e

Commits on Mar 6, 2016

• todos and whatever

  krakjoe

  committed
  3b9c9ff

  Copy full SHA for 3b9c9ff

• remove note

  krakjoe

  committed
  e016859

  Copy full SHA for e016859

• exception on uninitialized property access

  krakjoe

  committed
  8f74635

  Copy full SHA for 8f74635

• be tidy, don't leak, use flags ... other things, probably

  krakjoe

  committed
  70e0e4d

  Copy full SHA for 70e0e4d

• some tests ...

  krakjoe

  committed
  5a07809

  Copy full SHA for 5a07809

• fixed todo

  krakjoe

  committed
  9303e6d

  Copy full SHA for 9303e6d

• set flags correctly, remove todo

  krakjoe

  committed
  b3e15ca

  Copy full SHA for b3e15ca

• unused var

  krakjoe

  committed
  3dfb8c2

  Copy full SHA for 3dfb8c2

• another test

  krakjoe

  committed
  8c51aac

  Copy full SHA for 8c51aac

• rename function so it makes sense

  krakjoe

  committed
  37e169c

  Copy full SHA for 37e169c

Commits on Mar 7, 2016

• use flags here

  krakjoe

  committed
  149cb01

  Copy full SHA for 149cb01

• unexpected

  krakjoe

  committed
  52b184e

  Copy full SHA for 52b184e

• more words in error message

  krakjoe

  committed
  bd4368c

  Copy full SHA for bd4368c

• inheritance checks

  krakjoe

  committed
  0f265a3

  Copy full SHA for 0f265a3

• a todo

  krakjoe

  committed
  027f0a1

  Copy full SHA for 027f0a1

• nope

  krakjoe

  committed
  df9556b

  Copy full SHA for df9556b

• some more resolution stuff

  krakjoe

  committed
  64bce1e

  Copy full SHA for 64bce1e

• more inheritance stuff

  krakjoe

  committed
  3f56cd9

  Copy full SHA for 3f56cd9

• fix ast pretty printer

  krakjoe

  committed
  95eed91

  Copy full SHA for 95eed91

• refactor a little

  krakjoe

  committed
  ab3e992

  Copy full SHA for ab3e992

• add unset test

  krakjoe

  committed
  48c98ab

  Copy full SHA for 48c98ab

• abominable reading ahead of the unknown ... in the dark, scarily .... boo

  krakjoe

  committed
  0b4fb46

  Copy full SHA for 0b4fb46

• some mo tests

  krakjoe

  committed
  4d496ef

  Copy full SHA for 4d496ef

• fixes and more stuff

  krakjoe

  committed
  95a9e0d

  Copy full SHA for 95a9e0d

• woops

  krakjoe

  committed
  49ea1df

  Copy full SHA for 49ea1df

• don't check private property types during inheritance

  krakjoe

  committed
  b557f8b

  Copy full SHA for b557f8b

• check type on declaration

  krakjoe

  committed
  c957e75

  Copy full SHA for c957e75

• more tests, check initial value types

  krakjoe

  committed
  c156399

  Copy full SHA for c156399

• remove todo

  krakjoe

  committed
  861287a

  Copy full SHA for 861287a

• @TazeTSchnitzel rescued me from hell ...

  krakjoe

  committed
  f7f8c1b

  Copy full SHA for f7f8c1b

Commits on Mar 8, 2016

• better error messages

  krakjoe

  committed
  ce47372

  Copy full SHA for ce47372

• cache class entry in property info

  krakjoe

  committed
  7159da6

  Copy full SHA for 7159da6

• nothing

  krakjoe

  committed
  ef2531c

  Copy full SHA for ef2531c

• resolve property type

  krakjoe

  committed
  414fb83

  Copy full SHA for 414fb83

• add void check during compile

  krakjoe

  committed
  8095119

  Copy full SHA for 8095119

• tidy

  krakjoe

  committed
  f5fdbf1

  Copy full SHA for f5fdbf1

• allow overflow of int->long, deref container in fetch_obj_w

  krakjoe

  committed
  8679c7a

  Copy full SHA for 8679c7a

• functions are good ?

  krakjoe

  committed
  40b1409

  Copy full SHA for 40b1409

• more refactor

  krakjoe

  committed
  6077171

  Copy full SHA for 6077171

• urm ... we'll want a return value that makes sense

  krakjoe

  committed
  6e961f0

  Copy full SHA for 6e961f0

• remove todo

  krakjoe

  committed
  a98b4b3

  Copy full SHA for a98b4b3

• ...

  krakjoe

  committed
  0825a9d

  Copy full SHA for 0825a9d

• betterness

  krakjoe

  committed
  abdde6e

  Copy full SHA for abdde6e

Commits on Mar 9, 2016

• restrict declaration groups

  krakjoe

  committed
  7d12158

  Copy full SHA for 7d12158

• comments

  krakjoe

  committed
  2c3e242

  Copy full SHA for 2c3e242

• nulling these seems like a good idea

  krakjoe

  committed
  e5afe08

  Copy full SHA for e5afe08

• use flags here

  krakjoe

  committed
  fb1ef8a

  Copy full SHA for fb1ef8a

• use flags here too

  krakjoe

  committed
  b4ec5eb

  Copy full SHA for b4ec5eb

• test widening, fix uninitialized access check

  krakjoe

  committed
  90e18db

  Copy full SHA for 90e18db

• description corrections

  krakjoe

  committed
  17f749e

  Copy full SHA for 17f749e

• can never be an object at compile time

  krakjoe

  committed
  476805f

  Copy full SHA for 476805f

• more verify in fetch_obj_r

  krakjoe

  committed
  c7306b5

  Copy full SHA for c7306b5

• add tests for obj_read_r coerced value

  krakjoe

  committed
  1fa8106

  Copy full SHA for 1fa8106

• fix binary assign helper

  krakjoe

  committed
  b9f8e85

  Copy full SHA for b9f8e85

• woops

  krakjoe

  committed
  8dbdbf9

  Copy full SHA for 8dbdbf9

• update test desc

  krakjoe

  committed
  4e8988a

  Copy full SHA for 4e8988a

• delay check for constant/ast during compile

  krakjoe

  committed
  3f24be0

  Copy full SHA for 3f24be0

• add test for that^

  krakjoe

  committed
  373b2a5

  Copy full SHA for 373b2a5

• moar tests

  krakjoe

  committed
  d2ab6d2

  Copy full SHA for d2ab6d2

• refactor switch

  krakjoe

  committed
  fa835f3

  Copy full SHA for fa835f3

• squish branches

  krakjoe

  committed
  1d8a9d7

  Copy full SHA for 1d8a9d7

• disallow typed static properties, throw core errors for internal class stuff

  krakjoe

  committed
  fb4f14f

  Copy full SHA for fb4f14f

• makes no sense

  krakjoe

  committed
  5817fa3

  Copy full SHA for 5817fa3

• add tests for inheritance of private props

  krakjoe

  committed
  d195bce

  Copy full SHA for d195bce

Commits on Mar 10, 2016

• export type from ast ... note that there are still outstanding bugs in AST exporter not connected to this RFC

  krakjoe

  committed
  2beab02

  Copy full SHA for 2beab02

• cleanup tests

  krakjoe

  committed
  109ee15

  Copy full SHA for 109ee15

• fix func arg fetch handler

  krakjoe

  committed
  86ea6ed

  Copy full SHA for 86ea6ed

• fix mixing typed and untyped properties, add another test for that

  krakjoe

  committed
  9a8fb9e

  Copy full SHA for 9a8fb9e

Commits on Mar 11, 2016

• reflection changes

  krakjoe

  committed
  0d5d801

  Copy full SHA for 0d5d801

• the same changes, but nicer

  krakjoe

  committed
  29f80f3

  Copy full SHA for 29f80f3

• better if this makes sense ... I think

  krakjoe

  committed
  61da1b9

  Copy full SHA for 61da1b9

• ReflectionProperty::hasType

  krakjoe

  committed
  2fde206

  Copy full SHA for 2fde206

• fix trait inheritance

  krakjoe

  committed
  7ed980e

  Copy full SHA for 7ed980e

• woops

  krakjoe

  committed
  113dc9d

  Copy full SHA for 113dc9d

• typed properties need to be undef initial value

  krakjoe

  committed
  db9e574

  Copy full SHA for db9e574

Commits on Mar 16, 2016

• only allow widening int to float at runtime

  krakjoe

  committed
  87f1a37

  Copy full SHA for 87f1a37

Commits on Mar 17, 2016

• with much regret and sadness ... use strict types directive

  krakjoe

  committed
  4c7404c

  Copy full SHA for 4c7404c

• fix binary assign op surpriseness

  krakjoe

  committed
  8da4950

  Copy full SHA for 8da4950

• merge

  krakjoe

  committed
  f3ffc3e

  Copy full SHA for f3ffc3e

• stuff

  krakjoe

  committed
  d80750e

  Copy full SHA for d80750e

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  krakjoe

  committed
  37fe31f

  Copy full SHA for 37fe31f

• an woops

  krakjoe

  committed
  3628c34

  Copy full SHA for 3628c34

Commits on Mar 18, 2016

• lift unset restriction, possibly temporarily while we argue about stuff ...

  krakjoe

  committed
  72e330a

  Copy full SHA for 72e330a

• add test

  krakjoe

  committed
  90fde77

  Copy full SHA for 90fde77

• tidy up vm stuff

  krakjoe

  committed
  8ce9014

  Copy full SHA for 8ce9014

• some consistency

  krakjoe

  committed
  d2df329

  Copy full SHA for d2df329

Commits on Mar 19, 2016

• this kind of type verification only happens at runtime

  krakjoe

  committed
  d01e02b

  Copy full SHA for d01e02b

• info always available

  krakjoe

  committed
  e3e46f0

  Copy full SHA for e3e46f0

• improve error message to distinguish between arg by reference and by reference assignment

  krakjoe

  committed
  5037a74

  Copy full SHA for 5037a74

• not needed

  krakjoe

  committed
  b2d5f55

  Copy full SHA for b2d5f55

• check in rw fetch, not sure about this ?

  krakjoe

  committed
  5e57cda

  Copy full SHA for 5e57cda

Commits on Mar 20, 2016

• just make travis run again

  krakjoe

  committed
  896a4a6

  Copy full SHA for 896a4a6

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  krakjoe

  committed
  449ca5d

  Copy full SHA for 449ca5d

• the next opline always exists

  krakjoe

  committed
  baa0997

  Copy full SHA for baa0997

• require guard here too

  krakjoe

  committed
  8886795

  Copy full SHA for 8886795

• delay fetching iterator until after guard

  krakjoe

  committed
  658fc85

  Copy full SHA for 658fc85

• --indentation

  krakjoe

  committed
  1fd296d

  Copy full SHA for 1fd296d

• fix return by ref

  krakjoe

  committed
  eed867a

  Copy full SHA for eed867a

Commits on Mar 21, 2016

• do not allow send ref

  krakjoe

  committed
  fced030

  Copy full SHA for fced030

• add yield by reference guard

  krakjoe

  committed
  1dfbed4

  Copy full SHA for 1dfbed4

• guard add array element

  krakjoe

  committed
  b1543e5

  Copy full SHA for b1543e5

• use api for stuff ... doh

  krakjoe

  committed
  3a057cb

  Copy full SHA for 3a057cb

• inheritance fixes

  krakjoe

  committed
  bc450bb

  Copy full SHA for bc450bb

Commits on Mar 22, 2016

• woops

  krakjoe

  committed
  8a8d97a

  Copy full SHA for 8a8d97a

Commits on Mar 24, 2016

• separate proeprty type verification and error routine, fix display of private member names

  krakjoe

  committed
  be570b0

  Copy full SHA for be570b0

Commits on Mar 26, 2016

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  krakjoe

  committed
  f1e0152

  Copy full SHA for f1e0152

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  krakjoe

  committed
  46bffb2

  Copy full SHA for 46bffb2

Commits on Mar 27, 2016

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  krakjoe

  committed
  9fc0b75

  Copy full SHA for 9fc0b75

Commits on Mar 30, 2016

• better detection

  krakjoe

  committed
  4f1b2e1

  Copy full SHA for 4f1b2e1

• caches and things ... Thanks Dmitry :)

  krakjoe

  committed
  e48ecd8

  Copy full SHA for e48ecd8

• fix foreach, possibly ...

  krakjoe

  committed
  efe506a

  Copy full SHA for efe506a

Commits on Apr 4, 2016

• fix foreach

  Show description for c6eb6d2
  krakjoe

  committed
  c6eb6d2

  Copy full SHA for c6eb6d2

• change decl groups

  krakjoe

  committed
  cce2414

  Copy full SHA for cce2414

Commits on Apr 5, 2016

• overflow consistency

  krakjoe

  committed
  8f3ad60

  Copy full SHA for 8f3ad60

• moar consistent ... even if strange

  krakjoe

  committed
  f13b0a3

  Copy full SHA for f13b0a3

• make var_dump more acceptable

  krakjoe

  committed
  dd6d5ad

  Copy full SHA for dd6d5ad

• better

  krakjoe

  committed
  a99e7d1

  Copy full SHA for a99e7d1

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  Show description for a684a36
  krakjoe

  committed
  a684a36

  Copy full SHA for a684a36

• haaaaaands

  krakjoe

  committed
  e7d8aa7

  Copy full SHA for e7d8aa7

• add overflowingness test

  krakjoe

  committed
  88ff051

  Copy full SHA for 88ff051

• make travis run

  krakjoe

  committed
  7e02f50

  Copy full SHA for 7e02f50

• fix test [ci skip]

  krakjoe

  committed
  7edbbae

  Copy full SHA for 7edbbae

Commits on Apr 6, 2016

• fix memory error in std_write_property

  krakjoe

  committed
  26e1afb

  Copy full SHA for 26e1afb

• fix another possible memory error

  krakjoe

  committed
  a2d6d5b

  Copy full SHA for a2d6d5b

• better guard here and use _ex to avoid ever reading type info, we know its an object

  krakjoe

  committed
  4674286

  Copy full SHA for 4674286

• don't perform check on inline properties on read, only for magic

  Show description for ff56cd6
  krakjoe

  committed
  ff56cd6

  Copy full SHA for ff56cd6

• use more efficient macro when possible

  krakjoe

  committed
  2181b0e

  Copy full SHA for 2181b0e

• fix test case given by dmitry ...

  krakjoe

  committed
  e8bac36

  Copy full SHA for e8bac36

• only need null check here

  krakjoe

  committed
  335ca97

  Copy full SHA for 335ca97

• use more efficient stuff here

  krakjoe

  committed
  239216a

  Copy full SHA for 239216a

• this was checked on write too

  krakjoe

  committed
  6f57c44

  Copy full SHA for 6f57c44

• safety for non standard objects, remove pointless check

  krakjoe

  committed
  e62942a

  Copy full SHA for e62942a

• some more improvements ... haaaands

  krakjoe

  committed
  48d5aec

  Copy full SHA for 48d5aec

Commits on Apr 7, 2016

• use api stuff here

  krakjoe

  committed
  3f8430e

  Copy full SHA for 3f8430e

• catch more cases here

  krakjoe

  committed
  f391d86

  Copy full SHA for f391d86

• nothin to see here ...

  krakjoe

  committed
  304ff49

  Copy full SHA for 304ff49

Commits on May 23, 2016

• improve performance

  krakjoe

  committed
  2a5daa7

  Copy full SHA for 2a5daa7

• cold error path

  krakjoe

  committed
  9461e37

  Copy full SHA for 9461e37

• optimize all the things, thanks @bwoebi

  krakjoe

  committed
  fcaf14a

  Copy full SHA for fcaf14a

• more perf stuff

  krakjoe

  committed
  ecfb1e3

  Copy full SHA for ecfb1e3

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  Show description for f284596
  krakjoe

  committed
  f284596

  Copy full SHA for f284596

• dtor correct thing

  krakjoe

  committed
  a3e98d7

  Copy full SHA for a3e98d7

• dtor tmp

  krakjoe

  committed
  19de3fc

  Copy full SHA for 19de3fc

• check correct variable

  krakjoe

  committed
  fce9549

  Copy full SHA for fce9549

• Optimize & fix value reassign

  bwoebi

  committed
  47003bd

  Copy full SHA for 47003bd

• Easy optimization: constant assignment to objects will always succeed after it succeeded at least once

  bwoebi

  committed
  9282b82

  Copy full SHA for 9282b82

• Optimize property fetching and fix edge cases with __get()

  bwoebi

  committed
  403dabf

  Copy full SHA for 403dabf

Commits on May 24, 2016

• Disallow functions to set references and bad types

  bwoebi

  committed
  6a0e3c9

  Copy full SHA for 6a0e3c9

• missing colons

  krakjoe

  committed
  7eeda09

  Copy full SHA for 7eeda09

• Merge branch 'master' into typed-properties

  Show description for c2712a5
  dstogov

  committed
  c2712a5

  Copy full SHA for c2712a5

• Fixed white-spaces

  dstogov

  committed
  ce442f9

  Copy full SHA for ce442f9

• Revert insignificant formatting changes to minimize the patch against master

  dstogov

  committed
  25ed1f2

  Copy full SHA for 25ed1f2

• Fix passed zval reassignments (opcache.protect_memory=1)

  bwoebi

  committed
  758076a

  Copy full SHA for 758076a

• Respect also immutable values

  bwoebi

  committed
  e5f9ada

  Copy full SHA for e5f9ada

• Added tests

  dstogov

  committed
  88def3f

  Copy full SHA for 88def3f

• Added test (error message should be the same independently of called function)

  dstogov

  committed
  4b28b0d

  Copy full SHA for 4b28b0d

• Fixed Zend/tests/type_declarations/typed_properties_044.phpt (error message should be the same independently of called function)

  dstogov

  committed
  2ce08ca

  Copy full SHA for 2ce08ca

• Fixed memory leaks

  dstogov

  committed
  4705b9f

  Copy full SHA for 4705b9f

• Avoid type check for dynamic properties

  dstogov

  committed
  62b6bef

  Copy full SHA for 62b6bef

• Removed "safety" code for non standard zend objects.

  Show description for d27efdb
  dstogov

  committed
  d27efdb

  Copy full SHA for d27efdb

• Fixed memory leaks

  dstogov

  committed
  68bb52e

  Copy full SHA for 68bb52e

• Fixed test (NULL is no compatible with "int" and should produce a error)

  dstogov

  committed
  a1e3ea3

  Copy full SHA for a1e3ea3

• Get rid of zend_verify_scalar_property_type(), use common zend_verify_scalar_property_type() instead.

  dstogov

  committed
  4aae938

  Copy full SHA for 4aae938

• Optimized zend_verify_property_type()

  dstogov

  committed
  59b8a85

  Copy full SHA for 59b8a85

• Avoid type check for dynamic properties

  dstogov

  committed
  d46584f

  Copy full SHA for d46584f

• Added support for nullable typed properties

  dstogov

  committed
  ff19dec

  Copy full SHA for ff19dec

• Added test

  dstogov

  committed
  7d0654e

  Copy full SHA for 7d0654e

• Fix further invalid source zval overwrites

  bwoebi

  committed
  852606c

  Copy full SHA for 852606c

Commits on May 25, 2016

• Merge branch 'master' into typed-properties

  Show description for 142e1da
  dstogov

  committed
  142e1da

  Copy full SHA for 142e1da

• Reverted incomplete fix

  dstogov

  committed
  03861bd

  Copy full SHA for 03861bd

• Fixed test

  dstogov

  committed
  be071cd

  Copy full SHA for be071cd

• A better to fix for source zval separation on type conversion caused by weak property type check.

  dstogov

  committed
  c992fcf

  Copy full SHA for c992fcf

• Changed behavior of uninitialized nullable properties (accoding to conversation with Joe)

  dstogov

  committed
  f4b4051

  Copy full SHA for f4b4051

• Revert useless changes

  dstogov

  committed
  e657bf8

  Copy full SHA for e657bf8

• Removed useless check (references are never fetched using FETCH_OBJ_RW)

  dstogov

  committed
  d46695d

  Copy full SHA for d46695d

• Removed duplicate code

  dstogov

  committed
  a53b8ac

  Copy full SHA for a53b8ac

• Added support for nullavle types in AST pretty printer

  dstogov

  committed
  d248c27

  Copy full SHA for d248c27

• Revert useless change

  dstogov

  committed
  e1017f9

  Copy full SHA for e1017f9

• Added test (memory leaks)

  dstogov

  committed
  291d431

  Copy full SHA for 291d431

• "string" mat be also a valid "callable"

  dstogov

  committed
  40aa6c2

  Copy full SHA for 40aa6c2

• Removed unused function and macro

  dstogov

  committed
  3143597

  Copy full SHA for 3143597

• Optimization

  dstogov

  committed
  4506a70

  Copy full SHA for 4506a70

• Removed unused zend_object_fetch_property_type_info() and renamed zend_object_fetch_property_type_info_ex() into zend_object_fetch_property_type_info()

  dstogov

  committed
  05dd2e4

  Copy full SHA for 05dd2e4

• Fixed wrong exception when passing element of typed property by reference.

  dstogov

  committed
  023df77

  Copy full SHA for 023df77

• Optimisation

  dstogov

  committed
  56e2aaa

  Copy full SHA for 56e2aaa

• Added test (failed with valgrind)

  dstogov

  committed
  d7f313e

  Copy full SHA for d7f313e

• Added test (failed with valgrind)

  dstogov

  committed
  892994d

  Copy full SHA for 892994d

• Fixed memory leak

  dstogov

  committed
  b0dcf0c

  Copy full SHA for b0dcf0c

• Check type after constant resolution

  dstogov

  committed
  2019f66

  Copy full SHA for 2019f66

• Support for type checks of named constants in property default values.

  dstogov

  committed
  c304c6b

  Copy full SHA for c304c6b

Commits on May 26, 2016

• Fixed memory leaks

  dstogov

  committed
  b2cebf6

  Copy full SHA for b2cebf6

• Faster +=/++/--

  dstogov

  committed
  8bc2078

  Copy full SHA for 8bc2078

• Merge branch 'master' into typed-properties

  Show description for 26bf822
  dstogov

  committed
  26bf822

  Copy full SHA for 26bf822

• Fixed ZTS compatibility

  dstogov

  committed
  865686f

  Copy full SHA for 865686f

• Fixed compilation warning

  dstogov

  committed
  bf875fb

  Copy full SHA for bf875fb

• fixed white-spaces

  dstogov

  committed
  fc41cdc

  Copy full SHA for fc41cdc

• Optimization

  dstogov

  committed
  8beea3d

  Copy full SHA for 8beea3d

• Cleanup ext/reflection changes

  dstogov

  committed
  13c86d9

  Copy full SHA for 13c86d9

• Moved BG(unserialize_refs) into php_unserialize_data_t

  dstogov

  committed
  697b1b1

  Copy full SHA for 697b1b1

• Keep GCC from incorrect over-optimisation

  dstogov

  committed
  c5e45ff

  Copy full SHA for c5e45ff

Commits on May 27, 2016

• Removed useles code (default value should be already properly set in trait property)

  dstogov

  committed
  6bb1fa9

  Copy full SHA for 6bb1fa9

• Don't mess NULL and UNDEF default value back and force. Set proper value in first place.

  dstogov

  committed
  5811e86

  Copy full SHA for 5811e86

• Remove duplicate checks

  dstogov

  committed
  037da58

  Copy full SHA for 037da58

• Fixed incorrect argument types

  dstogov

  committed
  03e7112

  Copy full SHA for 03e7112

Commits on May 28, 2016

• Remove bad checks for simple property inheritance

  bwoebi

  committed
  cc19dc5

  Copy full SHA for cc19dc5

Commits on Jun 7, 2016

• Merge branch 'master' of https://github.com/php/php-src into typed-properties

  Show description for 3bbe52d
  krakjoe

  committed
  3bbe52d

  Copy full SHA for 3bbe52d

• changes prompted by review

  krakjoe

  committed
  de84f50

  Copy full SHA for de84f50

• make consistent with RFC (nullables)

  krakjoe

  committed
  71cda1b

  Copy full SHA for 71cda1b

• fix inheritance error

  krakjoe

  committed
  8eec27f

  Copy full SHA for 8eec27f