Zend/tests: organize some tests with sub directories (10) #17920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add directories for tests relating to - halting the compiler - `declare()` usage - exception handlers - `get_class_methods()` - `get_class_vars()` - `isset()` - name collisions As well as organizing a couple of tests into existing sub directories along the way Work towards phpGH-15631
Girgias
approved these changes
Feb 25, 2025
DanielEScherzer
added a commit
to DanielEScherzer/php-src
that referenced
this pull request
Feb 25, 2025
After discovering in August that Zend/tests had over 2500 entries, and that GitHub limits the display to only the first 1000 entries, I filed phpGH-15631 and sent a whole slew of patches to split up that directory and organize the tests a bit better. After the most recent patch, phpGH-17920, there are now once again fewer than 1,000 entries in that directory (for what seems to be the first time since the PHP 5.3 development cycle). Add a new GitHub action to the test suite that will ensure that no directory gets above 1,000 items - while the Zend/tests directory was the only one that had already hit that limit, there isn't much harm in checking all of the directories, and some of the extensions have hundreds of tests already and could conceivably hit the limit at some point. Closes phpGH-15631
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add directories for tests relating to
declare()usageget_class_methods()get_class_vars()isset()As well as organizing a couple of tests into existing sub directories along the way
Work towards GH-15631