Fix GH-17645: FPM with httpd ProxyPass does not decode script path #17896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsdos
approved these changes
Feb 23, 2025
bukka
force-pushed
the
fpm_gh17645_apache_pp_sft_decoding
branch
from
7dc17df to
f990379
Compare
bukka
added a commit
to bukka/php-src
that referenced
this pull request
Mar 2, 2025
This changes make FPM always decode SCRIPT_FILENAME when Apache ProxyPass or ProxyPassMatch is used. It also introduces a new INI option fastcgi.script_path_encoded that allows using the previous behavior of not decoding the path. The INI is introduced because there is a chance that some users could use encoded file paths in their file system as a workaround for the previous behavior. Close phpGH-17896
|
I do see on ARM64 macOS this fails: sapi/fpm/tests/log-suppress-output-request-body.phpt |
This changes make FPM always decode SCRIPT_FILENAME when Apache ProxyPass or ProxyPassMatch is used. It also introduces a new INI option fastcgi.script_path_encoded that allows using the previous behavior of not decoding the path. The INI is introduced because there is a chance that some users could use encoded file paths in their file system as a workaround for the previous behavior. Close phpGH-17896
bukka
force-pushed
the
fpm_gh17645_apache_pp_sft_decoding
branch
from
f990379 to
8fae6fc
Compare
|
Hmm very strange that it fails. I just tested on my mac arm64 and can't recreate it. It shows: Which looks more like missing fetch for last log output so it didn't match last line. Can't really think how it could be related to this change. |
|
The last run was fine so merging it. Let's see if it shows again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always decodes SCRIPT_FILENAME when Apache ProxyPass or ProxyPassMatch is used. It also introduces a new INI option fastcgi.script_path_encoded that allows using previous behavior of not decoding as there is a chance that some users could use encoded file paths in FS.