ext/sockets: php_set_inet*_addr using zend_string instead. #17845
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Feb 20, 2025
| @@ -128,7 +128,7 @@ static zend_result php_get_address_from_array(const HashTable *ht, const char *k | |||
| return FAILURE; | |||
| } | |||
| str = zval_get_tmp_string(val, &tmp_str); | |||
There was a problem hiding this comment.
Follow-up PR: but this should use the try API.
| @@ -605,7 +605,7 @@ static void from_zval_write_sin6_addr(const zval *zaddr_str, char *addr6, ser_co | |||
| zend_string *addr_str, *tmp_addr_str; | |||
|
|
|||
| addr_str = zval_get_tmp_string((zval *) zaddr_str, &tmp_addr_str); | |||
ext/sockets/sockets.c
Outdated
Comment on lines
1670
to
1671
| char *buf; | ||
| zend_string *addr; |
There was a problem hiding this comment.
I'm not sure the indent makes sense. Especially as the other ones are tab indented...
Suggested change
| char *buf; | |
| zend_string *addr; | |
| char *buf; | |
| zend_string *addr; |
devnexen
force-pushed
the
socket_set_inet_zend_string
branch
from
60ca9b7 to
8cfbe50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.