Skip to content

Gd upd #17823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Gd upd #17823

merged 1 commit into from
Feb 16, 2025

Conversation

devnexen
Copy link
Member

No description provided.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I'm not sure about the grammar (see nit below).

@@ -3191,7 +3191,7 @@ int gdImagePaletteToTrueColor(gdImagePtr src)
// due to a bug with a certain memory_limit INI value treshold,
// imagepalettetotruecolor crashes with even unrelated ZendMM allocations.
// See GH-17772 for an use case.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// See GH-17772 for an use case.
// See GH-17772 for a use case.

while at it, fix build warning "wrong" calloc arguments order
@devnexen devnexen merged commit 18df1e4 into php:master Feb 16, 2025
8 of 9 checks passed
@devnexen devnexen deleted the gd_upd branch February 16, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants