Skip to content

Use new known "self" and "parent" zend_strings #17766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Feb 11, 2025

No description provided.

@Girgias Girgias force-pushed the use-known-self-parent-zstr branch from 088ec8f to 77ee3da Compare February 11, 2025 19:58
@Girgias Girgias marked this pull request as ready for review February 11, 2025 21:43
@Girgias Girgias merged commit 65d4331 into php:master Feb 12, 2025
9 checks passed
@Girgias Girgias deleted the use-known-self-parent-zstr branch February 12, 2025 15:30
@dstogov
Copy link
Member

dstogov commented Feb 17, 2025

What is the reason for this change?
I remember, I tried similar change at the time I developed KNOWN STRINGS API. That time it made slight slowdown.
Did you check performance implication?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants