Skip to content

Fix GH-17745: zlib extension incorrectly handles object arguments #17750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-17745: zlib extension incorrectly handles object arguments #17750

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Feb 9, 2025 •
edited
Loading

Because of the "H" modifier in ZPP, there are two bugs:

  1. The stub is wrong and will cause a crash in debug mode.
  2. Non-dynamic properties are not read correctly because they are not
    DEINDIRECTed.

@nielsdos nielsdos requested a review from kocsismate as a code owner February 9, 2025 14:13
@nielsdos nielsdos linked an issue Feb 9, 2025 that may be closed by this pull request
zlib extension incorrectly handles object arguments #17745
Closed
@nielsdos
phpGH-17745 (zlib extension incorrectly handles object arguments)
0c744ab 
Because of the "H" modifier in ZPP, there are two bugs:

1) The stub is wrong and will cause a crash in debug mode.
2) Non-dynamic properties are not read correctly because they are not
   DEINDIRECTed.
@nielsdos nielsdos changed the title GH-17745 (zlib extension incorrectly handles object arguments) Fix GH-17745: zlib extension incorrectly handles object arguments Feb 9, 2025
@nielsdos nielsdos requested a review from Girgias February 10, 2025 21:09
Girgias
Girgias approved these changes Feb 11, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really not a fan of the H/A ZPP modifier, but this is a different topic all together. The bugfix seems correct to me.

@nielsdos nielsdos closed this in 4b5c29e Feb 11, 2025
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
@nielsdos @charmitro
Fix phpGH-17745: zlib extension incorrectly handles object arguments
7329a2d 
Because of the "H" modifier in ZPP, there are two bugs:

1) The stub is wrong and will cause a crash in debug mode.
2) Non-dynamic properties are not read correctly because they are not
   DEINDIRECTed.

Closes phpGH-17750.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: zlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zlib extension incorrectly handles object arguments
2 participants
@nielsdos @Girgias