Disallow calls to abstract __call() / __callStatic()
#17719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
arnaud-lb
approved these changes
Feb 6, 2025
Comment on lines
+1545
to
+1546
| zend_string_release_ex(fbc->common.function_name, 0); | ||
| zend_free_trampoline(fbc); |
There was a problem hiding this comment.
Unrelated, but I think we need this below in the ZEND_ACC_TRAIT case when EG(exception) is set.
There was a problem hiding this comment.
Indeed:
php: php-src/Zend/zend_execute_API.c:489: void shutdown_executor(void): Assertion `(executor_globals.trampoline).common.function_name == ((void*)0) || (compiler_globals.unclean_shutdown)' failed.
I'll make a separate PR for that.
dstogov
approved these changes
Feb 7, 2025
TimWolla
added a commit
that referenced
this pull request
Feb 7, 2025
* PHP-8.3: Disallow calls to abstract `__call()` / `__callStatic()` (#17719)
TimWolla
added a commit
that referenced
this pull request
Feb 7, 2025
* PHP-8.4: Disallow calls to abstract `__call()` / `__callStatic()` (#17719)
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17718