ext/pdo: Refactor validation of fetch mode in PDO statement #17699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
force-pushed
the
pdo-stm-set-fetch-mode
branch
from
249ece9 to
6440b24
Compare
nielsdos
requested changes
Feb 6, 2025
|
|
||
| if (mode < 0 || mode >= PDO_FETCH__MAX) { | ||
| /* Mode must be a positive */ | ||
| if (mode_and_flags < 0 || mode_and_flags >= PDO_FIRST_INVALID_FLAG) { |
There was a problem hiding this comment.
I don't think this change is right. What if mode is equal to 15? This number doesn't correspond to a real mode but it will not trigger the mode_and_flags >= PDO_FIRST_INVALID_FLAG condition.
There was a problem hiding this comment.
Right, I'll add a test for this.
There was a problem hiding this comment.
Okay, just this test then and then it's good to go.
There was a problem hiding this comment.
Actually this is properly guarded by the switch (mode) { below, but the test just ensure this continues to be the case.
This affects the value of the fetch mode flags
Co-authored-by: Niels Dossche <7771979+nielsdos@users.noreply.github.com>
Girgias
force-pushed
the
pdo-stm-set-fetch-mode
branch
from
492357e to
0cf1e6b
Compare
nielsdos
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.