Relax timezone_IDforWindowsID_basic2.phpt expectations #17669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently, some ICU versions report "America/Los_Angeles" for the `ZZ` case, what matches the behavior of ICU 76.1 (on Windows). Possibly, there has been some bug fix backport on some systems. Anyhow, either seems fine, so we're not picky about that.
nielsdos
approved these changes
Feb 2, 2025
|
Thank you Christoph. We should apply to 8.1 indeed. |
|
Applied to PHP-8.1+. Can have a separate look into merging the test cases. |
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
Apparently, some ICU versions report "America/Los_Angeles" for the `ZZ` case, what matches the behavior of ICU 76.1 (on Windows). Possibly, there has been some bug fix backport on some systems. Anyhow, either seems fine, so we're not picky about that. Closes phpGH-17669.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, some ICU versions report "America/Los_Angeles" for the
ZZcase, what matches the behavior of ICU 76.1 (on Windows). Possibly, there has been some bug fix backport on some systems. Anyhow, either seems fine, so we're not picky about that.Maybe we should merge this test case with timezone_IDforWindowsID_basic_icu76_1.phpt right away. And possibly we
shortshould apply the fix to PHP-8.1+.