Skip to content

zend_execute: Fix misleading UnhandledMatchError messages when exception_string_param_max_len=0 #17601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Jan 27, 2025

This also fixes a leak of non-string values if zend.exception_ignore_args=1.


To be discussed: Is zend.exception_ignore_args=1 being ignored a bug that should be fixed for PHP 8.4 (or earlier)?

…eption_string_param_max_len=0`

This also fixes a leak of non-string values if `zend.exception_ignore_args=1`.
@TimWolla
Copy link
Member Author

To be discussed: Is zend.exception_ignore_args=1 being ignored a bug that should be fixed for PHP 8.4 (or earlier)?

Created a explicit issue for that (#17618). Fix is in #17619. Will rebase this PR for the exception_string_param_max_len change after that one is merged.

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. of type string does seem preferable over '...' to me when max_len is 0.

@TimWolla TimWolla merged commit 5052b32 into php:master Jan 31, 2025
9 checks passed
@TimWolla TimWolla deleted the unhandled-match-error-misleading branch January 31, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants