Skip to content

Fixed GH-17398: Decrease BCG's refcount before error #17594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed GH-17398: Decrease BCG's refcount before error #17594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 68 additions & 34 deletions ext/bcmath/bcmath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,23 +183,28 @@ PHP_FUNCTION(bcadd)

if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&second, ZSTR_VAL(right)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

bc_add (first, second, &result, scale);

bc_free_num(&first);
bc_free_num(&second);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&second);
bc_free_num(&result);
};
}
}
/* }}} */

Expand Down Expand Up @@ -234,23 +239,28 @@ PHP_FUNCTION(bcsub)

if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&second, ZSTR_VAL(right)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

bc_sub (first, second, &result, scale);

bc_free_num(&first);
bc_free_num(&second);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&second);
bc_free_num(&result);
};
}
}
/* }}} */

Expand Down Expand Up @@ -285,19 +295,24 @@ PHP_FUNCTION(bcmul)

if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&second, ZSTR_VAL(right)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

bc_multiply (first, second, &result, scale);

bc_free_num(&first);
bc_free_num(&second);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&second);
bc_free_num(&result);
Expand Down Expand Up @@ -336,22 +351,27 @@ PHP_FUNCTION(bcdiv)

if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&second, ZSTR_VAL(right)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

if (!bc_divide(first, second, &result, scale)) {
zend_throw_exception_ex(zend_ce_division_by_zero_error, 0, "Division by zero");
goto cleanup;
goto fail;
}

bc_free_num(&first);
bc_free_num(&second);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&second);
bc_free_num(&result);
Expand Down Expand Up @@ -390,22 +410,27 @@ PHP_FUNCTION(bcmod)

if (php_str2num(&first, ZSTR_VAL(left)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&second, ZSTR_VAL(right)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

if (!bc_modulo(first, second, &result, scale)) {
zend_throw_exception_ex(zend_ce_division_by_zero_error, 0, "Modulo by zero");
goto cleanup;
goto fail;
}

bc_free_num(&first);
bc_free_num(&second);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&second);
bc_free_num(&result);
Expand Down Expand Up @@ -446,43 +471,47 @@ PHP_FUNCTION(bcpowmod)

if (php_str2num(&bc_base, ZSTR_VAL(base_str)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&bc_expo, ZSTR_VAL(exponent_str)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&bc_modulus, ZSTR_VAL(modulus_str)) == FAILURE) {
zend_argument_value_error(3, "is not well-formed");
goto cleanup;
goto fail;
}

raise_mod_status status = bc_raisemod(bc_base, bc_expo, bc_modulus, &result, scale);
switch (status) {
case BASE_HAS_FRACTIONAL:
zend_argument_value_error(1, "cannot have a fractional part");
goto cleanup;
goto fail;
case EXPO_HAS_FRACTIONAL:
zend_argument_value_error(2, "cannot have a fractional part");
goto cleanup;
goto fail;
case EXPO_IS_NEGATIVE:
zend_argument_value_error(2, "must be greater than or equal to 0");
goto cleanup;
goto fail;
case MOD_HAS_FRACTIONAL:
zend_argument_value_error(3, "cannot have a fractional part");
goto cleanup;
goto fail;
case MOD_IS_ZERO:
zend_throw_exception_ex(zend_ce_division_by_zero_error, 0, "Modulo by zero");
goto cleanup;
goto fail;
case OK:
bc_free_num(&bc_base);
bc_free_num(&bc_expo);
bc_free_num(&bc_modulus);
RETVAL_STR(bc_num2str_ex(result, scale));
break;
bc_free_num(&result);
return;
EMPTY_SWITCH_DEFAULT_CASE();
}

cleanup: {
fail: {
bc_free_num(&bc_base);
bc_free_num(&bc_expo);
bc_free_num(&bc_modulus);
Expand Down Expand Up @@ -522,30 +551,35 @@ PHP_FUNCTION(bcpow)

if (php_str2num(&first, ZSTR_VAL(base_str)) == FAILURE) {
zend_argument_value_error(1, "is not well-formed");
goto cleanup;
goto fail;
}

if (php_str2num(&bc_exponent, ZSTR_VAL(exponent_str)) == FAILURE) {
zend_argument_value_error(2, "is not well-formed");
goto cleanup;
goto fail;
}

/* Check the exponent for scale digits and convert to a long. */
if (bc_exponent->n_scale != 0) {
zend_argument_value_error(2, "cannot have a fractional part");
goto cleanup;
goto fail;
}
long exponent = bc_num2long(bc_exponent);
if (exponent == 0 && (bc_exponent->n_len > 1 || bc_exponent->n_value[0] != 0)) {
zend_argument_value_error(2, "is too large");
goto cleanup;
goto fail;
}

bc_raise(first, exponent, &result, scale);

bc_free_num(&first);
bc_free_num(&bc_exponent);
RETVAL_STR(bc_num2str_ex(result, scale));

cleanup: {
bc_free_num(&result);
return;

fail: {
bc_free_num(&first);
bc_free_num(&bc_exponent);
bc_free_num(&result);
Expand Down
10 changes: 10 additions & 0 deletions ext/bcmath/tests/gh17398.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--TEST--
GH-17398 (bcmul memory leak)
--EXTENSIONS--
bcmath
--FILE--
<?php
bcmul('0', '0', 2147483647);
?>
--EXPECTF--
Fatal error: Allowed memory size of %d bytes exhausted%s(tried to allocate %d bytes) in %s on line %d
Loading