ext/sodium: sodium_crypto_aead_(aes256gcm/aefis128l)_decrypt adjustments #17588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a size_t could not be greater than SIZE_MAX here.
|
@devnexen Please see Slack. |
to potentially protect against buffer overflow.
|
This looks good already, but it seems we have a whole bunch of checks involving SIZE_MAX and string lengths. It's highly likely all of them should be changed to ZSTR_MAX_LEN (but check this). |
|
I think we should coordinate with upstream. |
|
If that's the case, then upstream is already behind with what is in php... |
|
There's still a few of the form |
devnexen
force-pushed
the
libsodium_adjust
branch
from
cb5237a to
1601de9
Compare
nielsdos
approved these changes
Jan 26, 2025
I think both implementations have diverged over time. E.g. search for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a size_t could not be greater than SIZE_MAX here.