Skip to content

Use preinstalled MySQL for Windows CI #17570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cmb69
Copy link
Member

@cmb69 cmb69 commented Jan 25, 2025

Recent hosted GH Windows runners already have MySQL preinstalled, so there is no particular need to install it again via Chocolatey or other means.

If we ever need to address more specific needs, we may want to have a look at https://github.com/ankane/setup-mysql.

Closes GH-17561.

Recent hosted GH Windows runners already have MySQL preinstalled, so
there is no particular need to install it again via Chocolatey or other
means.

If we ever need to address more specific needs, we may want to have a
look at <https://github.com/ankane/setup-mysql>.
@cmb69 cmb69 force-pushed the cmb/mysql-ci-win-8.1 branch from 53f3348 to 2c7e6f9 Compare January 25, 2025 00:44
@cmb69 cmb69 changed the title Attempt to fix GH-17561 for PHP-8.1 Use preinstalled MySQL for Windows CI Jan 25, 2025
@cmb69 cmb69 marked this pull request as ready for review January 25, 2025 01:28
@cmb69 cmb69 mentioned this pull request Jan 25, 2025
@cmb69
Copy link
Member Author

cmb69 commented Jan 25, 2025

Apparently, this works also for master with MySQL 8.0.40: https://github.com/php/php-src/actions/runs/12959248999/job/36151146856

Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @cmb69!

@iluuu1994
Copy link
Member

We should also look into upgrading to 8.4 (or 9.1) soon, normal support for 8.0 ends in 3 months, and extended support one year later.

@cmb69 cmb69 closed this in a403b76 Jan 25, 2025
@cmb69 cmb69 deleted the cmb/mysql-ci-win-8.1 branch January 25, 2025 16:45
@cmb69
Copy link
Member Author

cmb69 commented Jan 25, 2025

We should also look into upgrading to 8.4 (or 9.1) soon, normal support for 8.0 ends in 3 months, and extended support one year later.

Might be a good idea, but at least for now I'm happy if CI is green again.

@iluuu1994
Copy link
Member

@cmb69
Copy link
Member Author

cmb69 commented Jan 26, 2025

I had a Chocolatey error a few hours earlier, and retriggering the job worked. I've now retriggered this one, too.

But yeah, if that happens too often, we should probably switch to https://github.com/ankane/setup-sqlserver (or set up SQLServer manually).

@cmb69
Copy link
Member Author

cmb69 commented Jan 26, 2025

But yeah, if that happens too often,

Oh, also happened for a nightly job. Apparently, Chocolately downloads the full installation package (266MB), while usually you download only a minimal installer (4MB) which fetches the rest from the Web as it goes. I'll have a look.

charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
Recent hosted GH Windows runners already have MySQL preinstalled, so
there is no particular need to install it again via Chocolatey or other
means.

If we ever need to address more specific needs, we may want to have a
look at <https://github.com/ankane/setup-mysql>.

Closes phpGH-17561.
Closes phpGH-17570.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI WINDOWS_X64_ZTS rate-limited on dev.mysql.com causing failures.
2 participants