Skip to content

ext/intl: Call DateTimeInterface::getTimestamp() directly #17487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Jan 16, 2025

No description provided.

"object", func);
intl_errors_set(err, U_INTERNAL_PROGRAM_ERROR,
message, 1);
auto *getTimestampMethod = static_cast<zend_function *>(zend_hash_str_find_ptr(&obj->ce->function_table, ZEND_STRL("gettimestamp")));
Copy link
Member

@devnexen devnexen Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: auto getTimestampMethod, it is deduced to zend_function * without needing the *

Copy link
Member

@devnexen devnexen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

@Girgias Girgias merged commit a100450 into php:master Jan 19, 2025
9 of 10 checks passed
@Girgias Girgias deleted the intl-call-function-refacto branch January 19, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants