Use pkg-config for ext/ldap without a directory #17441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing check is not very good. OpenLDAP has been shipping a pkg-config file for a while now, and that's preferable over trying to manually find it. Note that for older OpenLDAP or non-OpenLDAP implementations, a directory can still be passed to use the old logic. Note that Oracle LDAP is busted and going away soon; I'm not sure for other LDAP implementations. Tested on macOS 14.
thesamesam
reviewed
Jan 11, 2025
|
If there's no objections, I'll merge this within the week. |
|
Sure, sounds good to me. I'm sorry, I don't have much time to test this at the moment. I trust you've tested it already enough... Otherwise, if anything is found later it can be resolved through bugs etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing check is not very good. OpenLDAP has been shipping a pkg-config file for a while now, and that's preferable over trying to manually find it.
Note that for older OpenLDAP or non-OpenLDAP implementations, a directory can still be passed to use the old logic. Note that Oracle LDAP is busted and going away soon; I'm not sure for other LDAP implementations.
Tested on macOS 14.