zend_hrtime: Fix build for macOS without clock_gettime_nsec_np()

[jorgsowa]

One declaration was missed in #17089 and because of that complication is failing.

Example:

/Users/x/php-src/Zend/zend_hrtime.h:92:47: error: use of undeclared identifier 'zend_hrtime_timerlib_info'
92 | return (zend_hrtime_t)mach_absolute_time() * zend_hrtime_timerlib_info.numer / zend_hrtime_timerlib_info.denom;

[TimWolla]

Thank you, the change looks good to me. Can you clarify which macOS version you are using on what hardware so we can add that to the commit message? My understanding is that all recent macOS systems support the ZEND_HRTIME_PLATFORM_APPLE_GETTIME_NSEC variant.

[jorgsowa]

That's true, but because ZEND_HRTIME_PLATFORM_APPLE is not defined then mach/mach_time.h is not imported and the functions are not available. I'm using macOS 15.2 so the latest one.

[TimWolla]

is not defined then mach/mach_time.h is not imported and the functions are not available

Yes, clock_gettime_nsec_np is sitting in time.h, so it's intentional to not import mach_time.h for use of clock_gettime_nsec_np. If the build fails for you and succeeds with this PR, then this means that clock_gettime_nsec_np is not getting used for you, which is suprising given you are running on macOS 15.2.

To double check my understanding is correct: Can you confirm that ./configure reports clock_gettime_nsec_np ... no for you?

[jorgsowa]

It displays correctly checking whether clock_gettime_nsec_np is declared... yes. So everything works correctly except for cases where clock_gettime_nsec_np is not available so probably for older systems.

[TimWolla]

It displays correctly checking whether clock_gettime_nsec_np is declared... yes.

Okay, then I don't understand why this bug failed the build for you. Or did you find this by reading the code?

[jorgsowa]

I didn't run the script ./buildconf before I ran ./configure.... So for the first time it failed, I found the issue in the code and I created the PR.

Afterward, I ran all the setup to compile PHP and everything worked well. As I use the newset macOS I only suppose it may cause issues on older machines.

[TimWolla]

Thank you for clarifying!