Skip to content

zend_ast: Remove unused ZEND_AST_EXIT #17417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2025
Merged

zend_ast: Remove unused ZEND_AST_EXIT #17417

merged 1 commit into from
Jan 9, 2025

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Jan 9, 2025

This AST node is no longer used since exit() was made a real function in GH-13483.

@TimWolla
zend_ast: Remove unused ZEND_AST_EXIT
634a5de 
This AST node is no longer used since `exit()` was made a real function in
phpGH-13483.
@TimWolla TimWolla requested a review from Girgias January 9, 2025 09:43
Girgias
Girgias approved these changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this is now handled by the parser directly.

@TimWolla TimWolla merged commit e421a44 into php:master Jan 9, 2025
10 checks passed
@TimWolla TimWolla deleted the remove-zend-ast-exit branch January 9, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

Assignees
No one assigned
Labels
ABI break Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @Girgias