ext/sockets: socket_addrinfo_lookup and other few internal changes #17363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
some_more_sockets_changes
branch
from
945d3e3 to
e1f2907
Compare
Girgias
requested changes
Jan 5, 2025
ext/sockets/sockets.c
Outdated
| if (failed) { | ||
| zend_argument_type_error(3, "\"ai_flags\" key must be of type int, %s given", zend_zval_type_name(hint)); | ||
| if (zhints) { | ||
| if (!HT_IS_PACKED(Z_ARRVAL_P(zhints))) { |
There was a problem hiding this comment.
Maybe flip the condition and don't have an else branch?
Suggested change
| if (!HT_IS_PACKED(Z_ARRVAL_P(zhints))) { | |
| if (UNEXPECTED(HT_IS_PACKED(Z_ARRVAL_P(zhints)))) { | |
| /* Throw error */ | |
| } | |
| /* Happy path */ |
- socket_addrinfo_lookup throws when hints is an indexed array. - socket_get_option hardcoding size outputs to user when data size known.
devnexen
force-pushed
the
some_more_sockets_changes
branch
from
d86ec31 to
026aa8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
size known.