ext/socket: socket_addrinfo_lookup check hints array. #17300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Jan 2, 2025
| zend_argument_type_error(3, "\"ai_flags\" key must be of type int, %s given", zend_zval_type_name(hint)); | ||
| RETURN_THROWS(); | ||
| } | ||
| hints.ai_flags = (int)val; |
There was a problem hiding this comment.
Probably there should be a range check to see if the val can fit in a C int, but I'm happy to leave this for a follow-up PR
| zend_argument_type_error(3, "\"ai_socktype\" key must be of type int, %s given", zend_zval_type_name(hint)); | ||
| RETURN_THROWS(); | ||
| } | ||
| hints.ai_socktype = (int)val; |
| zend_argument_type_error(3, "\"ai_protocol\" key must be of type int, %s given", zend_zval_type_name(hint)); | ||
| RETURN_THROWS(); | ||
| } | ||
| hints.ai_protocol = (int)val; |
| zend_argument_type_error(3, "\"ai_family\" key must be of type int, %s given", zend_zval_type_name(hint)); | ||
| RETURN_THROWS(); | ||
| } | ||
| hints.ai_family = (int)val; |
Comment on lines
6
to
8
| <?php | ||
| try { | ||
| socket_addrinfo_lookup('127.0.0.1', 2000, array( |
devnexen
force-pushed
the
socket_addrinfo_exception
branch
from
470b6ed to
41a03c3
Compare
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 2, 2025
devnexen
added a commit
to devnexen/php-src
that referenced
this pull request
Jan 2, 2025
devnexen
added a commit
that referenced
this pull request
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.