Fix ini quantity parsing bugs #17274
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the code less error-prone.
This was
linked to
issues
Dec 26, 2024
Girgias
approved these changes
Dec 27, 2024
arnaud-lb
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
This looks good to me.
In hindsight, a comment before the call to zend_ini_consume_quantity_prefix() would be useful to show why we check if the string has an other prefix. Something along the lines of "STRTOULL may silently ignore a prefix of whitespace, sign, and base prefix, which would be invalid at this position".
|
I'll add a comment in the merge. |
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
Closes phpGH-17274.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No change to ZEND_STRTOL or anything like that, as that's kind of tangential and this is a stable branch anyway.