[WIP] Add a new flag TOKEN_OBJECT to token_get_all(). #1727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the flag is used, toket_get_all() will return an array of PhpToken objects instead of the current mix of strings and associative arrays.
|
@realityking fix conflicts please :) In addition, such changes do require an internals discussion and RFC, please move forward with those things ... alternatively, if you consider this work abandoned, please close this PR. |
|
It would be nice to evaluate performance and memory usage of this. |
|
PR #2430 has an updated and optimized implementation of this feature. I've also started an internals discussion here: http://markmail.org/message/ool5j6towowawr4r Unfortunately there was no consensus on this change, so introducing it will require an RFC :/ I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the flag is used, toket_get_all() will return an array of PhpToken objects instead of the current mix of strings and associative arrays.
I've opened this so I have a permanent url for the mailing list. Please don't merge it (yet).