Fix GH-17224: UAF in importNode #17230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Wrong document pointer is used for the namespace copy.
devnexen
approved these changes
Dec 21, 2024
Yeah, and there's many more simple fixes that could be put into 8.2 as well.
This particular bug has been here since 2009. Although people may hit this, it's probably unlikely and due to heap layout it may be the case that if you don't access particular properties of the object that you might survive a UAF crash. |
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
Wrong document pointer is used for the namespace copy. Closes phpGH-17230.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrong document pointer is used for the namespace copy.