Skip to content

Fix GH-17216: Trampoline crash on error #17219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-17216: Trampoline crash on error #17219

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

@nielsdos nielsdos commented Dec 19, 2024 •
edited
Loading 

Zend/zend_execute_API.c:518: void shutdown_executor(void): Assertion `(((zend_executor_globals *) (((char*) _tsrm_ls_cache)+(executor_globals_offset)))->trampoline).common.function_name == ((void*)0) || (((zend_compiler_globals *) (((char*) _tsrm_ls_cache)+(compiler_globals_offset)))->unclean_shutdown)' failed.

The error handling is incomplete on argument cleanup.

  1. The fci is not cleared which means that zend_free_trampoline() is never called.
  2. The cleaning for extra named arguments was missing, resulting in memory leak.

@nielsdos
Fix phpGH-17216: Trampoline crash on error
3bde646 
The error handling is incomplete on argument cleanup.
1. The fci is not cleared which means that zend_free_trampoline() is
   never called.
2. The cleaning for extra named arguments was missing, resulting in
   memory leak.
@nielsdos nielsdos linked an issue Dec 19, 2024 that may be closed by this pull request
Trampoline crash on error #17216
Closed
@nielsdos nielsdos marked this pull request as ready for review December 19, 2024 19:37
@nielsdos nielsdos requested a review from dstogov as a code owner December 19, 2024 19:37
@nielsdos nielsdos closed this in 2c3b56d Dec 20, 2024
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
@nielsdos @charmitro
Fix phpGH-17216: Trampoline crash on error
395297b 
The error handling is incomplete on argument cleanup.
1. The fci is not cleared which means that zend_free_trampoline() is
   never called.
2. The cleaning for extra named arguments was missing, resulting in
   memory leak.

Closes phpGH-17219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstogov dstogov dstogov approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trampoline crash on error
2 participants
@nielsdos @dstogov