Fix GH-17145: DOM memory leak #17147
Conversation
| echo $attr->value; | ||
| ?> | ||
| --EXPECT-- | ||
| n& |
There was a problem hiding this comment.
Looking at CI, is this & difference coming from libxml2 versions ?
There was a problem hiding this comment.
Looks like it :( It seems that the CI jobs using a more recent version of libxml have the correct output while the older versions do not. I'll run a bisect on libxml to see what commit in libxml fixed this.
There was a problem hiding this comment.
This was fixed in GNOME/libxml2@b8597f4, so it's a pretty recent fix and since distros are quite behind on libxml updates, it'll take some time for them to get this fix.
It would be possible to patch this in PHP too, but I'm going for a SKIPIF right now as I don't want to add more workarounds than we already have to be honest...
There was a problem hiding this comment.
Not really happy about dealing with these kinds of stuff
Because the use of RETURN instead of RETVAL, the freeing code could not be executed. This only is triggerable if the content of the attribute is mixed text and entities, so it wasn't noticed earlier.
Because the use of RETURN instead of RETVAL, the freeing code could not be executed. This only is triggerable if the content of the attribute is mixed text and entities, so it wasn't noticed earlier.