Skip to content

Fix duplicate pattern usage in Z_TRY_(ADD|DEL)REF_P #17097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Dec 9, 2024

GCC produces exactly the same binary with and without this change (without extensions), which demonstrates two things:

  • There is no additional register pressure.
  • All usages of the macros were correct in older branches, i.e. the expressions did not have any side-effects.

GCC produces exactly the same binary with and without this change (without
extensions), which demonstrates two things:

* There is no additional register pressure.
* All usages of the marcos were correct in older branches, i.e. the expressions
  did not have any side-effects.
@iluuu1994 iluuu1994 requested a review from dstogov as a code owner December 9, 2024 16:30
@iluuu1994 iluuu1994 merged commit 3590890 into php:master Dec 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant