Skip to content

ext/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros #17063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ext/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros #17063

wants to merge 1 commit into from

Conversation

SakiTakamachi
Copy link
Member

fixes #17061

@SakiTakamachi SakiTakamachi changed the title et/bcmath - Now Number::round() does not remove trailing zeros et/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros Dec 6, 2024
@SakiTakamachi SakiTakamachi changed the title et/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros et/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros Dec 6, 2024
@SakiTakamachi SakiTakamachi marked this pull request as ready for review December 6, 2024 09:18
@SakiTakamachi SakiTakamachi changed the title et/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros ext/bcmath - Fixed GH-17061: Now Number::round() does not remove trailing zeros Dec 6, 2024
@SakiTakamachi
Copy link
Member Author

Just resolved the NEWS conflict.

SakiTakamachi added a commit that referenced this pull request Dec 6, 2024
@SakiTakamachi
Merge branch 'PHP-8.4'
2bf3db0 
* PHP-8.4:
  Now `Number::round()` does not remove trailing zeros (#17063)
@SakiTakamachi SakiTakamachi deleted the fix/gh17061 branch December 6, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Assignees
No one assigned
Labels
Extension: bcmath
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SakiTakamachi @nielsdos