Fix GH-16957: Assertion failure in array_shift with self-referencing array #16970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng array We have an RC1 violation because we're immediately dereferencing and copying the resulting array in the test case. Instead, transfer the lifetime using ZVAL_COPY_VALUE and unwrap only after the internal iterator is reset.
bukka
approved these changes
Nov 27, 2024
iluuu1994
approved these changes
Nov 29, 2024
| @@ -3513,7 +3513,8 @@ PHP_FUNCTION(array_shift) | |||
| } | |||
| idx++; | |||
| } | |||
| RETVAL_COPY_DEREF(val); | |||
| ZVAL_COPY_VALUE(return_value, val); | |||
| @@ -3567,7 +3568,8 @@ PHP_FUNCTION(array_shift) | |||
| } | |||
| idx++; | |||
| } | |||
| RETVAL_COPY_DEREF(val); | |||
| ZVAL_COPY_VALUE(return_value, val); | |||
charmitro
pushed a commit
to wasix-org/php
that referenced
this pull request
Mar 13, 2025
…ng array We have an RC1 violation because we're immediately dereferencing and copying the resulting array in the test case. Instead, transfer the lifetime using RETVAL_COPY_VALUE and unwrap only after the internal iterator is reset. Closes phpGH-16970.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an RC1 violation because we're immediately dereferencing and copying the resulting array in the test case. Instead, transfer the lifetime using ZVAL_COPY_VALUE and unwrap only after the internal iterator is reset.
Targeting 8.3 because it's an unlikely bug to hit and 8.2 is almost EOL.