Make PDO_MYSQL_ATTR_DIRECT_QUERY a proper alias #16935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-tekiela
requested review from
kocsismate and
SakiTakamachi
as code owners
Girgias
reviewed
Nov 26, 2024
Comment on lines
33
to
39
| /** @cvalue PDO_MYSQL_ATTR_COMPRESS */ | ||
| public const int ATTR_COMPRESS = UNKNOWN; | ||
|
|
||
| /** @cvalue PDO_MYSQL_ATTR_DIRECT_QUERY */ | ||
| /** @cvalue PDO_ATTR_EMULATE_PREPARES */ | ||
| public const int ATTR_DIRECT_QUERY = UNKNOWN; | ||
|
|
||
| /** @cvalue PDO_MYSQL_ATTR_FOUND_ROWS */ |
There was a problem hiding this comment.
Maybe we should remove this from 8.4 as it is a new class and barely out? @php/release-managers-84 what do you think?
There was a problem hiding this comment.
PHP 8.4 is out already. Maybe it would be better to drop in 8.5?
There was a problem hiding this comment.
Yes, but I would consider this a "fix" to remove this useless constant, and considering it would be early in the release of it I'm not sure that it is that problematic, we fixed various named parameters up until PHP 8.0.3 to make them consistent.
|
Does this need an UPGRADING entry? |
|
It won't change anything for the user, right? If so, I don't think there's any need the UPGRADING entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.