Skip to content

Update code owners for mysqli and mysqlnd #16921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Conversation

bukka
Copy link
Member

@bukka bukka commented Nov 24, 2024

Added mysql and @kamil-tekiela to the CODEOWNERS for mysqli and mysqlnd

@kamil-tekiela just to check if you want to actually be there? I added you that it might be easier that ping you for those issues but understand if you don't want to be there as it might be a bit more notifications.

I added myself as I spent quite a lot of time on the protocol and improving the tests so can potentially help with reviews. Also planning to do some further work on those exts.

@bukka bukka requested a review from TimWolla as a code owner November 24, 2024 17:39
@kamil-tekiela
Copy link
Member

I was there at some point, but I don't know what happened that my name got removed. I'm happy to see my name back there.

@bukka
Copy link
Member Author

bukka commented Nov 24, 2024

Do you want to be in pdo_mysql as well? I just realised you did some fixes there in past as well...

@kamil-tekiela
Copy link
Member

You can put me in pdo_mysql as well

@bukka bukka force-pushed the mysql_codeownders branch from 8e96bf3 to ad69226 Compare November 24, 2024 17:54
@bukka bukka changed the base branch from master to PHP-8.2 November 24, 2024 18:44
@bukka bukka merged commit 866d8d7 into php:PHP-8.2 Nov 24, 2024
1 check passed
charmitro pushed a commit to wasix-org/php that referenced this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants