Fix GH-16799: Assertion failure at Zend/zend_vm_execute.h:7469 #16803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zend_is_callable_ex() can unfortunately emit a deprecation, and then a user error handler can throw an exception. This causes an assert failure at ZEND_VM_NEXT_OPCODE(). We fix this by checking if there's an exception after zend_is_callable_ex().
|
Actually, maybe it's better to reduce the number of checks by merging the exception check... |
iluuu1994
reviewed
Nov 15, 2024
Zend/tests/gh16799.phpt
Outdated
| @@ -0,0 +1,21 @@ | |||
| --TEST-- | |||
| GH-16799 (Assertion failure at Zend/zend_vm_execute.h:7469) | |||
There was a problem hiding this comment.
Nit: The lineno is pretty useless.
Zend/zend_vm_def.h
Outdated
| FREE_OP2(); | ||
| HANDLE_EXCEPTION(); | ||
| } | ||
|
|
||
| ZEND_ASSERT(!error); |
There was a problem hiding this comment.
This assert still applies? Can we move it up?
|
Note that the test fails as of PHP-8.4 due to closures now including filename:lineno. |
|
Yeah noticed that already and already put out a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zend_is_callable_ex() can unfortunately emit a deprecation, and then a user error handler can throw an exception. This causes an assert failure at ZEND_VM_NEXT_OPCODE(). We fix this by checking if there's an exception after zend_is_callable_ex().