Drop bogus ext/libxml dependency on ext/iconv #16801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no such dependency; only libxml2 depends on libiconv. So when php_libxml.dll is built, it needs to be linked against libiconv, or, when ext/iconv has been configured as static extension, against php8.dll.
cmb69
added
OS: Windows
Category: Build System
Extension: libxml
and removed
Category: Build System
Extension: libxml
labels
nielsdos
reviewed
Nov 14, 2024
nielsdos
approved these changes
Nov 15, 2024
cmb69
added a commit
to cmb69/php-src
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no such dependency; only libxml2 depends on libiconv. So when php_libxml.dll is built, it needs to be linked against libiconv, or, when ext/iconv has been configured as static extension, against php8.dll.
Note that I'm not happy with having php8.dll serving as drop-in DLL for a couple of libraries (grep for
ADD_DEF_FILE), but this is what we already have. We may revisit this issue later.