Patch libcurl.pc for macOS builds #16783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cURL 8.11.0 added a couple of packages to `Requires.private`, but these packages are irrelevant when building against a shared libcurl. For some reason, these private requirements are checked when we're doing `pkg-config --cflags` (that happens with the preinstalled pkg-config 0.29.2, as well as with pkgconf 2.3.0. To avoid further messing with these packages, we just drop the `Requires.private` line from libcurl.pc.
|
This should probably be applied to lower branches; not sure if we need 8.2 or 8.1. |
|
Thank you very much for taking care of this! Since we're using macOS 13 for all images, where the issue is also present, I believe we should backport to 8.1. |
|
Applied to PHP-8.1 and merged up. |
ericmann
pushed a commit
that referenced
this pull request
Nov 19, 2024
cURL 8.11.0 added a couple of packages to `Requires.private`, but these packages are irrelevant when building against a shared libcurl. For some reason, these private requirements are checked when we're doing `pkg-config --cflags` (that happens with the preinstalled pkg-config 0.29.2, as well as with pkgconf 2.3.0). To avoid further messing with these packages, we just drop the `Requires.private` line from libcurl.pc. See GH-16741 for more details. Closes GH-16783.
adoy
pushed a commit
that referenced
this pull request
Nov 19, 2024
cURL 8.11.0 added a couple of packages to `Requires.private`, but these packages are irrelevant when building against a shared libcurl. For some reason, these private requirements are checked when we're doing `pkg-config --cflags` (that happens with the preinstalled pkg-config 0.29.2, as well as with pkgconf 2.3.0). To avoid further messing with these packages, we just drop the `Requires.private` line from libcurl.pc. See GH-16741 for more details. Closes GH-16783.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cURL 8.11.0 added a couple of packages to
Requires.private, but these packages are irrelevant when building against a shared libcurl. For some reason, these private requirements are checked when we're doingpkg-config --cflags(that happens with the preinstalled pkg-config 0.29.2, as well as with pkgconf 2.3.0. To avoid further messing with these packages, we just drop theRequires.privateline from libcurl.pc.See also #16741.